unused imports removed and docstring detailed for sface and dlib

deepface/basemodels/ArcFace.py

@@ -1,7 +1,5 @@
-from typing import List
 import os
 import gdown
-import numpy as np
 from deepface.commons import package_utils, folder_utils
 from deepface.commons.logger import Logger
 from deepface.models.FacialRecognition import FacialRecognition

deepface/basemodels/DeepID.py

@@ -1,7 +1,5 @@
-from typing import List
 import os
 import gdown
-import numpy as np
 from deepface.commons import package_utils, folder_utils
 from deepface.commons.logger import Logger
 from deepface.models.FacialRecognition import FacialRecognition

deepface/basemodels/Dlib.py

@@ -25,8 +25,9 @@ class DlibClient(FacialRecognition):
 
     def forward(self, img: np.ndarray) -> List[float]:
         """
-        Find embeddings with Dlib model
+        Find embeddings with Dlib model.
-            Overwritten because it is different than regular models
+            This model necessitates the override of the forward method
+            because it is not a keras model.
         Args:
             img (np.ndarray): pre-loaded image in BGR
         Returns

deepface/basemodels/Facenet.py

@@ -1,7 +1,5 @@
-from typing import List
 import os
 import gdown
-import numpy as np
 from deepface.commons import package_utils, folder_utils
 from deepface.commons.logger import Logger
 from deepface.models.FacialRecognition import FacialRecognition

deepface/basemodels/FbDeepFace.py

@@ -1,8 +1,6 @@
-from typing import List
 import os
 import zipfile
 import gdown
-import numpy as np
 from deepface.commons import package_utils, folder_utils
 from deepface.commons.logger import Logger
 from deepface.models.FacialRecognition import FacialRecognition

deepface/basemodels/GhostFaceNet.py

@@ -1,10 +1,8 @@
 # built-in dependencies
 import os
-from typing import List
 
 # 3rd party dependencies
 import gdown
-import numpy as np
 import tensorflow as tf
 
 # project dependencies

deepface/basemodels/OpenFace.py

@@ -1,8 +1,6 @@
-from typing import List
 import os
 import gdown
 import tensorflow as tf
-import numpy as np
 from deepface.commons import package_utils, folder_utils
 from deepface.commons.logger import Logger
 from deepface.models.FacialRecognition import FacialRecognition

deepface/basemodels/SFace.py

@@ -28,7 +28,8 @@ class SFaceClient(FacialRecognition):
     def forward(self, img: np.ndarray) -> List[float]:
         """
         Find embeddings with SFace model
-            Overwritten because it is different than regular models
+            This model necessitates the override of the forward method
+            because it is not a keras model.
         Args:
             img (np.ndarray): pre-loaded image in BGR
         Returns