From 8fbc194f29c79fb144212fac675dd182dc0121d7 Mon Sep 17 00:00:00 2001
From: Sefik Ilkin Serengil <serengil@gmail.com>
Date: Mon, 1 Jun 2020 14:52:23 +0300
Subject: [PATCH] alternative thresholds as comment

---
 deepface/commons/functions.py | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/deepface/commons/functions.py b/deepface/commons/functions.py
index da5719e..e006e0e 100644
--- a/deepface/commons/functions.py
+++ b/deepface/commons/functions.py
@@ -81,6 +81,18 @@ def initializeFolder():
 	"""
 	#----------------------------------
 
+"""
+TODO: C4.5 tree finds the following split points for cosine, euclidean, euclidean_l2 respectively.
+Check these thresholds in unit tests.
+vgg-face: 0.3147, 0.4764, 0.7933
+facenet: 0.4062, 11.2632, 0.9014
+openface: 0.1118, 0.4729, 0.4729
+deepface: 0.1349, 42.2178, 0.5194
+"""
+
+"""
+TODO: create an ensemble method
+"""
 def findThreshold(model_name, distance_metric):
 	
 	threshold = 0.40