From d750c2b28e669127ecd3e1184eee10fcd11613b8 Mon Sep 17 00:00:00 2001 From: Nelson Dominguez Date: Sat, 11 Nov 2023 17:25:40 +0100 Subject: [PATCH 1/2] style: split instructions into logical units --- Dockerfile | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Dockerfile b/Dockerfile index 8a9800d..31adfd6 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,10 +1,12 @@ #base image FROM python:3.8 LABEL org.opencontainers.image.source https://github.com/serengil/deepface + # ----------------------------------- # create required folder RUN mkdir /app RUN mkdir /app/deepface + # ----------------------------------- # Copy required files from repo into image COPY ./deepface /app/deepface @@ -15,30 +17,37 @@ COPY ./api/service.py /app/ COPY ./requirements.txt /app/ COPY ./setup.py /app/ COPY ./README.md /app/ + # ----------------------------------- # switch to application directory WORKDIR /app + # ----------------------------------- # update image os RUN apt-get update RUN apt-get install ffmpeg libsm6 libxext6 -y + # ----------------------------------- # if you will use gpu, then you should install tensorflow-gpu package # RUN pip install --trusted-host pypi.org --trusted-host pypi.python.org --trusted-host=files.pythonhosted.org tensorflow-gpu + # ----------------------------------- # install deepface from pypi release (might be out-of-the-date) # RUN pip install --trusted-host pypi.org --trusted-host pypi.python.org --trusted-host=files.pythonhosted.org deepface # ----------------------------------- # install deepface from source code (always up-to-date) RUN pip install --trusted-host pypi.org --trusted-host pypi.python.org --trusted-host=files.pythonhosted.org -e . + # ----------------------------------- # some packages are optional in deepface. activate if your task depends on one. # RUN pip install --trusted-host pypi.org --trusted-host pypi.python.org --trusted-host=files.pythonhosted.org cmake==3.24.1.1 # RUN pip install --trusted-host pypi.org --trusted-host pypi.python.org --trusted-host=files.pythonhosted.org dlib==19.20.0 # RUN pip install --trusted-host pypi.org --trusted-host pypi.python.org --trusted-host=files.pythonhosted.org lightgbm==2.3.1 + # ----------------------------------- # environment variables ENV PYTHONUNBUFFERED=1 + # ----------------------------------- # run the app (re-configure port if necessary) EXPOSE 5000 From 189d742f7c44428c420b535b04d209ea7dea7731 Mon Sep 17 00:00:00 2001 From: Nelson Dominguez Date: Sat, 11 Nov 2023 17:34:14 +0100 Subject: [PATCH 2/2] docs: improve build steps comments --- Dockerfile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index 31adfd6..3916b1a 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -#base image +# base image FROM python:3.8 LABEL org.opencontainers.image.source https://github.com/serengil/deepface @@ -28,11 +28,11 @@ RUN apt-get update RUN apt-get install ffmpeg libsm6 libxext6 -y # ----------------------------------- -# if you will use gpu, then you should install tensorflow-gpu package +# if you plan to use a GPU, you should install the 'tensorflow-gpu' package # RUN pip install --trusted-host pypi.org --trusted-host pypi.python.org --trusted-host=files.pythonhosted.org tensorflow-gpu # ----------------------------------- -# install deepface from pypi release (might be out-of-the-date) +# install deepface from pypi release (might be out-of-date) # RUN pip install --trusted-host pypi.org --trusted-host pypi.python.org --trusted-host=files.pythonhosted.org deepface # ----------------------------------- # install deepface from source code (always up-to-date)