From 3ecaffd427a9f359ddf4e8c9aff4d4954d05ff81 Mon Sep 17 00:00:00 2001 From: Stenzek Date: Mon, 7 Apr 2025 20:47:29 +1000 Subject: [PATCH] dep/reshadefx: Don't unconditionally emit point size variable Metal compiler doesn't like it. And we're only using triangles at the moment anyway. --- dep/reshadefx/src/effect_codegen_spirv.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dep/reshadefx/src/effect_codegen_spirv.cpp b/dep/reshadefx/src/effect_codegen_spirv.cpp index 994b1377e..299a1231a 100644 --- a/dep/reshadefx/src/effect_codegen_spirv.cpp +++ b/dep/reshadefx/src/effect_codegen_spirv.cpp @@ -1543,6 +1543,8 @@ private: emit_load(position, false))); } +#if 0 + // Disabled because it breaks on MacOS/Metal - point size should not be defined for a non-point primitive. // Add code that sets the point size to a default value (in case this vertex shader is used with point primitives) if (point_size_variable == 0 && func.type == shader_type::vertex) { @@ -1554,6 +1556,7 @@ private: // gl_PointSize = 1.0 emit_store(point_size, emit_constant({ type::t_float, 1, 1 }, 1)); } +#endif leave_block_and_return(0); leave_function();