github/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2025-07-24 02:50:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

MediaCapture: Fix use-after-free when starting

Browse Source
This commit is contained in:
Stenzek 2025-07-20 21:09:43 +10:00
parent 161637e3b7
commit a5b46f7676
No known key found for this signature in database
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/util/media_capture.cpp
View File

@ -1117,13 +1117,6 @@ MediaCaptureMF::CreateVideoEncodeTransform(std::string_view codec, u32 frame_rat
ComPtr<IMFTransform> transform;
hr = transforms[0]->ActivateObject(IID_PPV_ARGS(transform.GetAddressOf()));
if (transforms)
wrap_MFHeapFree(transforms);
if (FAILED(hr)) [[unlikely]]
{
Error::SetHResult(error, "Encoder ActivateObject() failed: ", hr);
return nullptr;
}
{
LPWSTR transform_name;
UINT32 transform_name_length;
@ -1134,6 +1127,14 @@ MediaCaptureMF::CreateVideoEncodeTransform(std::string_view codec, u32 frame_rat
StringUtil::WideStringToUTF8String(std::wstring_view(transform_name, transform_name_length)));
CoTaskMemFree(transform_name);
}
wrap_MFHeapFree(transforms);
}
if (FAILED(hr)) [[unlikely]]
{
Error::SetHResult(error, "Encoder ActivateObject() failed: ", hr);
return nullptr;
}
*use_async_transform = false;