From 0aca6ff26216755bee5a82b47e49f299c31d8415 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Marcos?= Date: Fri, 18 Apr 2025 15:14:46 -0300 Subject: [PATCH] Always run CI checks with the default features when matrix_all_combinations is false, previously we would run all CI with the features disabled and then have 1 run for each with it enabled now, they are always enabled, and we add 1 run that disable 1 of them when matrix_all_combinations is true this doesn't change the fact that we'll test all combinations --- .../workflows/build-artifacts-and-run-tests.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-artifacts-and-run-tests.yml b/.github/workflows/build-artifacts-and-run-tests.yml index 5c1bc0d..fa9e1fd 100644 --- a/.github/workflows/build-artifacts-and-run-tests.yml +++ b/.github/workflows/build-artifacts-and-run-tests.yml @@ -37,9 +37,9 @@ jobs: strategy: fail-fast: false matrix: - feature-unrar: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[false]')}} - feature-use-zlib: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[false]')}} - feature-use-zstd-thin: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[false]')}} + feature-unrar: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[true]')}} + feature-use-zlib: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[true]')}} + feature-use-zstd-thin: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[true]')}} target: # native - x86_64-unknown-linux-gnu @@ -75,12 +75,12 @@ jobs: use-cross: true - target: armv7-unknown-linux-musleabihf use-cross: true - # features (unless `matrix_all_combinations` is true, we only run these on linux-gnu) - - feature-unrar: true + # features (unless `matrix_all_combinations` is true, we'll only run with these disabled on linux-gnu) + - feature-unrar: false target: x86_64-unknown-linux-gnu - - feature-use-zlib: true + - feature-use-zlib: false target: x86_64-unknown-linux-gnu - - feature-use-zstd-thin: true + - feature-use-zstd-thin: false target: x86_64-unknown-linux-gnu steps: