github/ouch
1
1
Fork 0
mirror of https://github.com/ouch-org/ouch.git synced 2025-06-06 11:35:45 +00:00
Code Issues 15 Packages Projects Releases Wiki Activity

Merge pull request #139 from ouch-org/simplify-cli-canonicalize-input-treatment

Browse Source 
Simplify cli canonicalize implementation
This commit is contained in:
João Marcos Bezerra 2021-11-02 07:24:59 -03:00 committed by GitHub
commit 1b123a4dc2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/cli.rs
View File

@ -1,6 +1,7 @@
//! CLI related functions, uses the clap argparsing definitions from `opts.rs`.
use std::{
io,
path::{Path, PathBuf},
vec::Vec,
};
@ -8,7 +9,7 @@ use std::{
use clap::Parser;
use fs_err as fs;
use crate::{Error, Opts, QuestionPolicy, Subcommand};
use crate::{Opts, QuestionPolicy, Subcommand};
impl Opts {
/// A helper method that calls `clap::Parser::parse`.
@ -17,7 +18,7 @@ impl Opts {
/// 1. Make paths absolute.
/// 2. Checks the QuestionPolicy.
pub fn parse_args() -> crate::Result<(Self, QuestionPolicy)> {
let mut opts: Self = Self::parse();
let mut opts = Self::parse();
let (Subcommand::Compress { files, .. } | Subcommand::Decompress { files, .. }) = &mut opts.cmd;
*files = canonicalize_files(files)?;
@ -34,19 +35,6 @@ impl Opts {
}
}
fn canonicalize(path: impl AsRef<Path>) -> crate::Result<PathBuf> {
match fs::canonicalize(&path.as_ref()) {
Ok(abs_path) => Ok(abs_path),
Err(io_err) => {
if !path.as_ref().exists() {
Err(Error::FileNotFound(path.as_ref().into()))
} else {
Err(io_err.into())
}
}
}
}
fn canonicalize_files(files: &[impl AsRef<Path>]) -> crate::Result<Vec<PathBuf>> {
files.iter().map(canonicalize).collect()
fn canonicalize_files(files: &[impl AsRef<Path>]) -> io::Result<Vec<PathBuf>> {
files.iter().map(fs::canonicalize).collect()
}