github/ouch
1
1
Fork 0
mirror of https://github.com/ouch-org/ouch.git synced 2025-06-07 12:05:46 +00:00
Code Issues 15 Packages Projects Releases Wiki Activity

Make ZIP comment show in accessibility mode

Browse Source
This commit is contained in:
Anton Hermann 2021-11-23 18:41:23 +01:00
parent 1030eb0de9
commit 437b0c42ff
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/archive/zip.rs
View File

@ -158,8 +158,17 @@ where
fn check_for_comments(file: &ZipFile) { fn check_for_comments(file: &ZipFile) {
let comment = file.comment(); let comment = file.comment();
if !comment.is_empty() { if !comment.is_empty() {
// TODO: is this important? // Zip file comments seem to be pretty rare, but if they are used,
info!(inaccessible, "Found comment in {}: {}", file.name(), comment); // they may contain important information, so better show them
//
// "The .ZIP file format allows for a comment containing up to 65,535 (216−1) bytes
// of data to occur at the end of the file after the central directory."
//
// If there happen to be cases of very long and unnecessary comments in
// the future, maybe asking the user if he wants to display the comment
// (informing him of its size) would be sensible for both normal and
// accessibility mode..
info!(accessible, "Found comment in {}: {}", file.name(), comment);
} }
} }