From c057d9c682433b73bfa1a4874b3c1856036a4274 Mon Sep 17 00:00:00 2001
From: Fabricio Dematte <fabriciodematte7p@gmail.com>
Date: Wed, 19 May 2021 21:35:50 -0300
Subject: [PATCH] add further flag testing to oof crate

---
 oof/src/lib.rs | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/oof/src/lib.rs b/oof/src/lib.rs
index c03fe5b..0c1e665 100644
--- a/oof/src/lib.rs
+++ b/oof/src/lib.rs
@@ -234,11 +234,29 @@ mod tests {
     }
 
     #[test]
-    fn test_unknown_short_flag() {
+    fn test_unknown_flags() {
         let result = setup_args_scenario("ouch a.zip -s b.tar.gz c.tar").unwrap_err();
         assert!(matches!(result, OofError::UnknownShortFlag('s')));
         let result = setup_args_scenario("ouch a.zip --foobar b.tar.gz c.tar").unwrap_err();
-        // TODO: assert `UnknownLongFlag` error
+        // TODO: Try removing the `_` from `_foobar`
+        let _foobar = "foobar".to_string();
+        assert!(matches!(result, OofError::UnknownLongFlag(_foobar)));
+    }
+
+    #[test]
+    fn test_incomplete_flags() {
+        // TODO: Try removing the `_` from `_incomplete_flag`
+        let _incomplete_flag = Flag::long("output_file").short('o');
+        let result = setup_args_scenario("ouch a.zip b.tar.gz c.tar -o").unwrap_err();
+        assert!(matches!(result, OofError::MissingValueToFlag(_incomplete_flag)));
+    }
+
+    #[test]
+    fn test_duplicated_flags() {
+        // TODO: Try removing the `_` from `_duplicated_flag`
+        let _duplicated_flag = Flag::long("output_file").short('o');
+        let result = setup_args_scenario("ouch a.zip b.tar.gz c.tar -o -o -o").unwrap_err();
+        assert!(matches!(result, OofError::DuplicatedFlag(_duplicated_flag)));
     }
 
     // asdasdsa