From c3b89b038dd1c3dc6b2031816c1e58be360f211f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Marcos?= <marcospb19@hotmail.com>
Date: Tue, 6 May 2025 00:27:43 -0300
Subject: [PATCH] improve misleading error message (#818)

Follow up to #817
---
 CHANGELOG.md     |  2 +-
 src/extension.rs | 29 ++++++++++++++---------------
 2 files changed, 15 insertions(+), 16 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4871cdc..232173a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -64,7 +64,7 @@ Categories Used:
 ### Improvements
 
 - Fix logging IO bottleneck [\#642](https://github.com/ouch-org/ouch/pull/642) ([AntoniosBarotsis](https://github.com/AntoniosBarotsis))
-- Support decompression  over stdin [\#692](https://github.com/ouch-org/ouch/pull/692) ([rcorre](https://github.com/rcorre))
+- Support decompression over stdin [\#692](https://github.com/ouch-org/ouch/pull/692) ([rcorre](https://github.com/rcorre))
 - Make `--format` more forgiving with the formatting of the provided format [\#519](https://github.com/ouch-org/ouch/pull/519) ([marcospb19](https://github.com/marcospb19))
 - Use buffered writer for list output [\#764](https://github.com/ouch-org/ouch/pull/764) ([killercup](https://github.com/killercup))
 - Disable smart unpack when `--dir` flag is provided in decompress command [\#782](https://github.com/ouch-org/ouch/pull/782) ([talis-fb](https://github.com/talis-fb))
diff --git a/src/extension.rs b/src/extension.rs
index 8a6304e..48be0cb 100644
--- a/src/extension.rs
+++ b/src/extension.rs
@@ -203,24 +203,23 @@ pub fn separate_known_extensions_from_name(path: &Path) -> Result<(&Path, Vec<Ex
         extensions.insert(0, extension);
         if extensions[0].is_archive() {
             if let Some((_, misplaced_extension)) = split_extension_at_end(name) {
-                return Err(FinalError::with_title("File extensions are invalid for operation")
-                    .detail(format!(
-                        "The archive extension '.{}' must come before any non-archive extensions, like '.{}'",
-                        extensions[0].display_text, misplaced_extension.display_text
-                    ))
-                    .detail(format!(
+                let mut error = FinalError::with_title("File extensions are invalid for operation").detail(format!(
+                    "The archive extension '.{}' can only be placed at the start of the extension list",
+                    extensions[0].display_text,
+                ));
+
+                if misplaced_extension.compression_formats == extensions[0].compression_formats {
+                    error = error.detail(format!(
                         "File: '{path:?}' contains '.{}' and '.{}'",
                         misplaced_extension.display_text, extensions[0].display_text,
-                    ))
-                    .detail(format!("'.{}' is an archive format", extensions[0].display_text))
-                    .detail(format!(
-                        "'.{}' isn't an archive format",
-                        misplaced_extension.display_text
-                    ))
+                    ));
+                }
+
+                return Err(error
                     .hint("You can use `--format` to specify what format to use, examples:")
-                    .hint("  ouch compress 1 2 file --format zip")
-                    .hint("  ouch decompress file --format gz")
-                    .hint("  ouch list archive --format zip")
+                    .hint("  ouch compress file.zip.zip file --format zip")
+                    .hint("  ouch decompress file --format zst")
+                    .hint("  ouch list archive --format tar.gz")
                     .into());
             }
             break;