From c737956a4e4fccca69b76e4ebb86fc9b26557108 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20M=2E=20Bezerra?= <marcospb19@hotmail.com>
Date: Wed, 23 Nov 2022 00:30:35 -0300
Subject: [PATCH] check for EOF when asking questions

when invoking Ouch from shell scripts, it is likely that questions will
be left unanswered with EOF, this commit fixes Ouch interpreting EOF as
Yes in Y/N questions
---
 src/utils/question.rs | 14 ++++++++++++--
 tests/utils.rs        |  1 +
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/utils/question.rs b/src/utils/question.rs
index a4ee4bb..4a77733 100644
--- a/src/utils/question.rs
+++ b/src/utils/question.rs
@@ -14,7 +14,7 @@ use fs_err as fs;
 use super::{strip_cur_dir, to_utf};
 use crate::{
     accessible::is_running_in_accessible_mode,
-    error::{Error, Result},
+    error::{Error, FinalError, Result},
     utils::{self, colors},
 };
 
@@ -145,7 +145,17 @@ impl<'a> Confirmation<'a> {
             io::stdout().flush()?;
 
             let mut answer = String::new();
-            io::stdin().read_line(&mut answer)?;
+            let bytes_read = io::stdin().read_line(&mut answer)?;
+
+            if bytes_read == 0 {
+                let error = FinalError::with_title("Unexpected EOF when asking question.")
+                    .detail("When asking the user:")
+                    .detail(format!("  \"{message}\""))
+                    .detail("Expected 'y' or 'n' as answer, but found EOF instead.")
+                    .hint("If using Ouch in scripting, consider using `--yes` and `--no`.");
+
+                return Err(error.into());
+            }
 
             answer.make_ascii_lowercase();
             match answer.trim() {
diff --git a/tests/utils.rs b/tests/utils.rs
index a2b9231..b69ae0a 100644
--- a/tests/utils.rs
+++ b/tests/utils.rs
@@ -9,6 +9,7 @@ macro_rules! ouch {
     ($($e:expr),*) => {
         $crate::utils::cargo_bin()
             $(.arg($e))*
+            .arg("--yes")
             .unwrap();
     }
 }