From e15cb83bd4f36a765c8a04f4acb6298fe27d6f5c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Marcos?= Date: Mon, 5 May 2025 21:11:44 -0300 Subject: [PATCH] unrelated TODOs --- .github/workflows/build-artifacts-and-run-tests.yml | 2 ++ src/commands/mod.rs | 1 + 2 files changed, 3 insertions(+) diff --git a/.github/workflows/build-artifacts-and-run-tests.yml b/.github/workflows/build-artifacts-and-run-tests.yml index 3b53cff..695439b 100644 --- a/.github/workflows/build-artifacts-and-run-tests.yml +++ b/.github/workflows/build-artifacts-and-run-tests.yml @@ -37,6 +37,8 @@ jobs: strategy: fail-fast: false matrix: + # TODO: avoid exploding the matrix by removing unrar and bzip3 from the all combinations runs + # I can add a monthly run with all combinations feature-unrar: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[true]')}} feature-bzip3: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[true]')}} feature-use-zlib: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[false]')}} diff --git a/src/commands/mod.rs b/src/commands/mod.rs index c3363d1..fd1fc88 100644 --- a/src/commands/mod.rs +++ b/src/commands/mod.rs @@ -158,6 +158,7 @@ pub fn run( if let Some(format) = args.format { let format = parse_format_flag(&format)?; for path in files.iter() { + // TODO: use Error::Custom let file_name = path.file_name().ok_or_else(|| Error::NotFound { error_title: format!("{} does not have a file name", EscapedPathDisplay::new(path)), })?;