From 24a04eee41a551eb83c49496be9a8f357af04f59 Mon Sep 17 00:00:00 2001 From: Zhongxian Jia Date: Tue, 13 Mar 2018 16:12:59 +0800 Subject: [PATCH] [FIX] fix empty result for '--diff' and print style --- pipreqs/pipreqs.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pipreqs/pipreqs.py b/pipreqs/pipreqs.py index 0186832..ed94b4b 100755 --- a/pipreqs/pipreqs.py +++ b/pipreqs/pipreqs.py @@ -349,7 +349,10 @@ def compare_modules(file_, imports): imports = [imports[i]["name"] for i in range(len(imports))] modules = [modules[i]["name"] for i in range(len(modules))] - modules_not_imported = set(modules) - set(imports) + # modules => declared in requirements + # imports => all modules needed + # not imported => all modules - declared + modules_not_imported = set(imports) - set(modules) return modules_not_imported @@ -359,7 +362,7 @@ def diff(file_, imports): modules_not_imported = compare_modules(file_, imports) logging.info( - "The following modules are in {} but do not seem to be imported: " + "The following modules are in {} but do not seem to be imported: \n" "{}".format(file_, ", ".join(x for x in modules_not_imported)))