github/pipreqs
1
1
Fork 0
mirror of https://github.com/bndr/pipreqs.git synced 2025-06-06 03:25:21 +00:00
Code Issues 3 Packages Projects Releases Wiki Activity

Merge pull request #111 from yonatanp/master

Browse Source 
bugfix: f.close() only required if open succeeded
This commit is contained in:
Vadim Kravcenko 2019-11-14 11:43:11 +01:00 committed by GitHub
commit 6ca1f42d4e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
pipreqs/pipreqs.py
View File

@ -310,9 +310,10 @@ def parse_requirements(file_):
logging.error("Failed on file: {}".format(file_)) logging.error("Failed on file: {}".format(file_))
raise raise
else: else:
data = [x.strip() for x in f.readlines() if x != "\n"] try:
finally: data = [x.strip() for x in f.readlines() if x != "\n"]
f.close() finally:
f.close()
data = [x for x in data if x[0].isalpha()] data = [x for x in data if x[0].isalpha()]
@ -376,16 +377,17 @@ def clean(file_, imports):
logging.error("Failed on file: {}".format(file_)) logging.error("Failed on file: {}".format(file_))
raise raise
else: else:
for i in f.readlines(): try:
if re_remove.match(i) is None: for i in f.readlines():
to_write.append(i) if re_remove.match(i) is None:
f.seek(0) to_write.append(i)
f.truncate() f.seek(0)
f.truncate()
for i in to_write: for i in to_write:
f.write(i) f.write(i)
finally: finally:
f.close() f.close()
logging.info("Successfully cleaned up requirements in " + file_) logging.info("Successfully cleaned up requirements in " + file_)