github/pipreqs
1
1
Fork 0
mirror of https://github.com/bndr/pipreqs.git synced 2025-07-20 08:50:01 +00:00
Code Issues 3 Packages Projects Releases Wiki Activity

Replace with statement with a try/except/else/finally block to narrow down problem in the future

Browse Source
This commit is contained in:
kxrd 2017-06-13 22:22:27 +02:00
parent 54be2d1c24
commit e7b8ddf72d
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pipreqs/pipreqs.py
View File

@ -244,11 +244,14 @@ def parse_requirements(file_):
delim = ["<", ">", "=", "!", "~"] # https://www.python.org/dev/peps/pep-0508/#complete-grammar
try:
with open(file_, "r") as f:
data = [x.strip() for x in f.readlines() if x != "\n"]
f = open_func(file_, "r")
except OSError:
logging.error("Failed on file: {}".format(file_))
raise
else:
data = [x.strip() for x in f.readlines() if x != "\n"]
finally:
f.close()
data = [x for x in data if x[0].isalpha()]
@ -303,16 +306,22 @@ def clean(file_, imports):
re_remove = re.compile("|".join(modules_not_imported))
to_write = []
with open(file_, "r+") as f:
try:
f = open_func(file_, "r+")
except OSError:
logging.error("Failed on file: {}".format(file_))
raise
else:
for i in f.readlines():
if re_remove.match(i) is None:
to_write.append(i)
f.seek(0)
f.truncate()
for i in to_write:
f.write(i)
finally:
f.close()
logging.info("Successfully cleaned up requirements in " + file_)