github/television
1
1
Fork 0
mirror of https://github.com/alexpasmantier/television.git synced 2025-06-07 03:55:23 +00:00
Code Issues 1 Packages Projects Releases Wiki Activity

perf(preview): remove temporary plaintext previews in favor of loading message preview (#10)

Browse Source 
* perf(preview): remove temporary plaintext previews in favor of a loading message

* linting

* dead code
This commit is contained in:
Alexandre Pasmantier 2024-11-11 13:49:46 +01:00 committed by GitHub
parent 81cf17bd5d
commit 62073d69cc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
crates/television/ui/preview.rs
View File

@ -110,6 +110,7 @@ impl Television {
Ok(())
}
#[allow(dead_code)]
const FILL_CHAR_SLANTED: char = '╱';
const FILL_CHAR_EMPTY: char = ' ';
@ -194,7 +195,7 @@ impl Television {
.build_meta_preview_paragraph(
inner,
PREVIEW_NOT_SUPPORTED_MSG,
Self::FILL_CHAR_SLANTED,
Self::FILL_CHAR_EMPTY,
)
.block(preview_block)
.alignment(Alignment::Left)
@ -203,7 +204,7 @@ impl Television {
.build_meta_preview_paragraph(
inner,
FILE_TOO_LARGE_MSG,
Self::FILL_CHAR_SLANTED,
Self::FILL_CHAR_EMPTY,
)
.block(preview_block)
.alignment(Alignment::Left)

15
crates/television_previewers/src/previewers/files.rs
View File

@ -69,6 +69,10 @@ impl FilePreviewer {
}
}
/// Get a preview for a file entry.
///
/// # Panics
/// Panics if seeking to the start of the file fails.
pub async fn preview(&mut self, entry: &entry::Entry) -> Arc<Preview> {
let path_buf = PathBuf::from(&entry.name);
@ -94,9 +98,8 @@ impl FilePreviewer {
FileType::Text => {
match File::open(&path_buf) {
Ok(file) => {
// insert a non-highlighted version of the preview into the cache
let reader = BufReader::new(&file);
let preview = plain_text_preview(&entry.name, reader);
// insert a loading preview into the cache
let preview = meta::loading(&entry.name);
self.cache_preview(
entry.name.clone(),
preview.clone(),
@ -104,8 +107,7 @@ impl FilePreviewer {
.await;
// compute the highlighted version in the background
let mut reader =
BufReader::new(file.try_clone().unwrap());
let mut reader = BufReader::new(file);
reader.seek(std::io::SeekFrom::Start(0)).unwrap();
self.compute_highlighted_text_preview(entry, reader)
.await;
@ -216,6 +218,8 @@ impl FilePreviewer {
}
Err(e) => {
warn!("Error computing highlights: {:?}", e);
let preview = meta::not_supported(&entry_c.name);
cache.lock().insert(entry_c.name.clone(), preview);
}
};
});
@ -281,6 +285,7 @@ impl FilePreviewer {
/// This should be enough to most standard terminal sizes
const TEMP_PLAIN_TEXT_PREVIEW_HEIGHT: usize = 200;
#[allow(dead_code)]
fn plain_text_preview(title: &str, reader: BufReader<&File>) -> Arc<Preview> {
debug!("Creating plain text preview for {:?}", title);
let mut lines = Vec::with_capacity(TEMP_PLAIN_TEXT_PREVIEW_HEIGHT);