github/television
1
1
Fork 0
mirror of https://github.com/alexpasmantier/television.git synced 2025-06-07 12:05:34 +00:00
Code Issues 1 Packages Projects Releases Wiki Activity

perf(ui): improve merging of continuous name match ranges (#109)

Browse Source 
### main
```
results_list            time:   [17.800 µs 17.836 µs 17.869 µs]
                        change: [-0.7235% -0.4176% -0.1185%] (p = 0.01 < 0.05)
                        Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild
```

### this branch
```
results_list            time:   [12.780 µs 12.789 µs 12.798 µs]
                        change: [-28.381% -28.218% -28.059%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  1 (1.00%) high mild
  4 (4.00%) high severe
```
This commit is contained in:
Alexandre Pasmantier 2024-12-09 14:08:28 +01:00 committed by GitHub
parent 5fb02c768f
commit 758bfc290a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
crates/television-channels/src/entry.rs
View File

@ -66,22 +66,21 @@ impl Entry {
self self
} }
#[allow(clippy::needless_return)] #[allow(clippy::needless_return)]
pub fn minimal_name_match_ranges(self) -> Option<Vec<(u32, u32)>> { pub fn minimal_name_match_ranges(&self) -> Option<Vec<(u32, u32)>> {
// This method takes the existing `name_match_ranges` // This method takes the existing `name_match_ranges`
// and merges contiguous ranges into the minimal equivalent // and merges contiguous ranges into the minimal equivalent
// set of ranges. If no ranges exist, it returns `None`. // set of ranges. If no ranges exist, it returns `None`.
if let Some(name_match_ranges) = self.name_match_ranges { if let Some(name_match_ranges) = &self.name_match_ranges {
let minimal_name_match_ranges: Vec<(u32, u32)> = name_match_ranges let minimal_name_match_ranges: Vec<(u32, u32)> =
.into_iter() name_match_ranges.iter().fold(Vec::new(), |mut acc, x| {
.fold(Vec::new(), |mut acc, x| {
if let Some(last) = acc.last_mut() { if let Some(last) = acc.last_mut() {
if last.1 == x.0 { if last.1 == x.0 {
last.1 = x.1 last.1 = x.1;
} else { } else {
acc.push(x); acc.push(*x);
} }
} else { } else {
acc.push(x); acc.push(*x);
} }
return acc; return acc;
}); });

2
crates/television-screen/src/results.rs
View File

@ -56,7 +56,7 @@ where
// entry name // entry name
let (entry_name, name_match_ranges) = make_matched_string_printable( let (entry_name, name_match_ranges) = make_matched_string_printable(
&entry.name, &entry.name,
entry.name_match_ranges.as_deref(), entry.minimal_name_match_ranges().as_deref(),
); );
let mut last_match_end = 0; let mut last_match_end = 0;
for (start, end) in name_match_ranges for (start, end) in name_match_ranges