chore(linting): add workspace lints (#228)

Hey, nice work. There's a lot of potential, and the idea of custom
channels with custom run commands is very appealing.

I was looking at the source, but clippy pedantic lints threw a lot of
warnings and I noticed the project did not have a linting profile. I
threw together a profile here, but it does leave a fair amount of
warnings in. Maybe some variation of this, or another linting profile
could be considered to guide future contributors on style decisions.
Cheers

---------

Co-authored-by: Alexandre Pasmantier <alex.pasmant@gmail.com>
This commit is contained in:
Osma S. Rautila 2025-01-06 19:24:56 +02:00 committed by GitHub
parent 76bff30759
commit da2396e19a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 38 additions and 1 deletions

View File

@ -123,3 +123,25 @@ lto = "fat"
[profile.deb]
inherits = "release"
debug = false
[lints]
workspace = true
[workspace.lints.clippy]
pedantic = { level = "warn", priority = -1 }
must_use_candidate = "allow"
too_many_lines = "allow"
missing_panics_doc = "allow"
missing_errors_doc = "allow"
module_name_repetitions = "allow"
cast_precision_loss = "allow"
map_unwrap_or = "allow"
return_self_not_must_use = "allow"
uninlined_format_args = "allow"
similar_names = "allow"
float_cmp = "allow"
implicit_hasher = "allow"
wildcard_imports = "allow"
from_iter_instead_of_collect = "allow"

View File

@ -30,3 +30,5 @@ lazy_static = "1.5.0"
toml = "0.8.19"
regex = "1.11.1"
[lints]
workspace = true

View File

@ -21,3 +21,5 @@ syn = "2.0.79"
[lib]
proc-macro = true
[lints]
workspace = true

View File

@ -15,3 +15,6 @@ rust-version.workspace = true
[dependencies]
nucleo = "0.5.0"
parking_lot = "0.12.3"
[lints]
workspace = true

View File

@ -34,3 +34,5 @@ simd = ["dep:simdutf8"]
zero-copy = []
default = ["zero-copy", "simd"]
[lints]
workspace = true

View File

@ -20,3 +20,6 @@ television-channels = { path = "../television-channels", version = "0.0.18" }
television-previewers = { path = "../television-previewers", version = "0.0.18" }
color-eyre = "0.6.3"
syntect = "5.2.0"
[lints]
workspace = true

View File

@ -27,3 +27,6 @@ unicode-width = "0.2.0"
[target.'cfg(windows)'.dependencies]
winapi-util = "0.1.9"
[lints]
workspace = true

View File

@ -218,7 +218,7 @@ impl Input {
None
} else {
let cursor = self.cursor;
self.value = "".into();
self.value = String::new();
self.cursor = 0;
Some(StateChanged {
value: true,