From fcf4b35272f10488697fb74e493c399e489c6c50 Mon Sep 17 00:00:00 2001 From: Alexandre Pasmantier <47638216+alexpasmantier@users.noreply.github.com> Date: Mon, 10 Mar 2025 22:16:20 +0100 Subject: [PATCH] ci: replace manual convco check and git hook by a dedicated ci step (#376) --- .github/workflows/ci.yml | 7 +++++++ Makefile | 8 -------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9cada8d..96ee100 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -46,3 +46,10 @@ jobs: components: clippy - name: Clippy Check run: cargo clippy -- -D warnings + + conventional-commits: + name: Conventional Commits + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: webiny/action-conventional-commits@v1.3.0 diff --git a/Makefile b/Makefile index b72c8f6..cd064f8 100644 --- a/Makefile +++ b/Makefile @@ -6,10 +6,6 @@ setup: @mkdir -p .git/hooks @echo "make fix" > .git/hooks/pre-commit @chmod +x .git/hooks/pre-commit - @echo "installing convco..." - @cargo install convco - @echo "make check-commits" > .git/hooks/pre-push - @chmod +x .git/hooks/pre-push @echo "Done" clean: @@ -62,7 +58,3 @@ publish: update-changelog: @echo "Updating changelog" @git cliff -o CHANGELOG.md - -check-commits: - @echo "Checking commits (see https://www.conventionalcommits.org/)" - @convco check origin/main..HEAD