- Improved determine channel logic, it will make easier to maintain
moving forward
- Fixed hint logic for preview, it had issues for stdin and ad-hoc
channels
- Override logic for CLI UI elements was not handled consistently
- Added few more tests
sometimes I want to tweak the previous search, or just run it again.
this solves that problem
---------
Co-authored-by: alexandre pasmantier <alex.pasmant@gmail.com>
This PR solves part of
https://github.com/alexpasmantier/television/issues/246, since hosting
our own apt repo is just the first step.
Right now it's a draft, because I put the CD code inside of the
[.github/workflows/static.yml](98a3d7b854/.github/workflows/static.yml)
file and this, most-likely, doesn't belong there. Where exactly to put
it will need to be discussed, but the requirements are:
- to start executing this code after we generate the `.deb` binary
- and to deploy the static GH pages content after we've executed this
code
I've deployed a test version of the `.deb` package to my GH pages and
you can actually already install `television` via `apt` like this:
```sh
# download the repository public key and put it in the trusted directory
curl -sS https://kapobajza.github.io/television/apt/repository-key.asc | sudo gpg --dearmor --yes -o /etc/apt/trusted.gpg.d/television.gpg
# put the repository download link inside the apt sources list
echo "deb https://kapobajza.github.io/television/apt stable main" | sudo tee /etc/apt/sources.list.d/television.list
sudo apt update
# install the package 🚀
sudo apt install television
```
---------
Co-authored-by: Kapobajza <kapobajza@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alex Pasmantier <47638216+alexpasmantier@users.noreply.github.com>
Co-authored-by: alexandre pasmantier <alex.pasmant@gmail.com>
cleaned up keybinding section from config
@alexpasmantier you had this code before, perhaps there was a reason for
it?
```rust
if cfg!(not(windows)) {
execute!(buffered_stderr, DisableMouseCapture)?;
}
```
- Migrate to a feature based UI
- Introduces television/features.rs with a flags-based Features type
(PREVIEW_PANEL, HELP_PANEL, STATUS_BAR, REMOTE_CONTROL).
- Per-feature configuration sections: [ui.preview_panel],
[ui.status_bar], [ui.remote_control], [ui.help_panel]
- Rename Keybinding panel ➜ Help panel
- CLI & housekeeping
- new CLI toggle --no-status-bar, updated docs and man page
- import clean up
before
```
cargo bench --bench main -- --save-baseline before
Finished `bench` profile [optimized] target(s) in 0.13s
Running benches/main.rs (target/release/deps/main-8151fda9d09b6257)
results_list time: [16.002 µs 16.095 µs 16.190 µs]
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
2 (2.00%) high mild
Benchmarking draw: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.6s, or reduce sample count to 80.
draw time: [2.0829 ms 2.2517 ms 2.4277 ms]
```
after
```
cargo bench --bench main -- --baseline before
Finished `bench` profile [optimized] target(s) in 0.08s
Running benches/main.rs (target/release/deps/main-8151fda9d09b6257)
results_list time: [8.2873 µs 8.3418 µs 8.3963 µs]
change: [-49.407% -48.880% -48.360%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) low mild
Benchmarking draw: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.4s, or reduce sample count to 90.
draw time: [1.3345 ms 1.4388 ms 1.5460 ms]
change: [-42.872% -36.105% -29.053%] (p = 0.00 < 0.05)
Performance has improved.
```
---------
Co-authored-by: Alex Pasmantier <47638216+alexpasmantier@users.noreply.github.com>
This PR adds support for customizing
* input_header
* preview_header
* preview_footer
all the items are of type MultiTemplate, this gives some flexibility
when showing the selected value, let's say on the preview header, if
it's long or you want only a section
---------
Co-authored-by: alexandre pasmantier <alex.pasmant@gmail.com>
