From dd257e919d346cf438e734862c2cca5d931bb09e Mon Sep 17 00:00:00 2001 From: geoffrey45 Date: Fri, 13 Jan 2023 18:10:39 +0300 Subject: [PATCH] fix coderefactor bot raised issues --- src/components/nav/Titles/Folder.vue | 1 - src/components/shared/NavSearchInput.vue | 3 +-- src/composables/favoriteHandler.ts | 4 ++-- src/composables/fetch/album.ts | 1 - src/config.ts | 2 +- src/utils/useCalculateSearchItemCount.ts | 6 ------ src/utils/useCreateTrackProps.ts | 2 -- src/utils/usePutCommas.ts | 2 +- 8 files changed, 5 insertions(+), 16 deletions(-) delete mode 100644 src/utils/useCalculateSearchItemCount.ts diff --git a/src/components/nav/Titles/Folder.vue b/src/components/nav/Titles/Folder.vue index 16e6ed2..774fc8f 100644 --- a/src/components/nav/Titles/Folder.vue +++ b/src/components/nav/Titles/Folder.vue @@ -104,7 +104,6 @@ onUpdated(() => { &::before { content: "∕"; - font-size: small; margin-right: $smaller; color: $gray2; font-size: 1rem; diff --git a/src/components/shared/NavSearchInput.vue b/src/components/shared/NavSearchInput.vue index d7f6fa3..82d4839 100644 --- a/src/components/shared/NavSearchInput.vue +++ b/src/components/shared/NavSearchInput.vue @@ -42,7 +42,7 @@ const { query: folderQuery } = storeToRefs(folder); const { query: albumQuery } = storeToRefs(album); const props = defineProps<{ - page: Routes | string; + page: typeof Routes | string; }>(); const inputRef = ref(); @@ -100,7 +100,6 @@ if (source) { .header-input { background-color: transparent; - outline: none; border: none; color: inherit; font-size: 1rem; diff --git a/src/composables/favoriteHandler.ts b/src/composables/favoriteHandler.ts index 7518d67..5804817 100644 --- a/src/composables/favoriteHandler.ts +++ b/src/composables/favoriteHandler.ts @@ -11,8 +11,8 @@ export default async function favoriteHandler( flag: boolean | undefined, type: favType, itemhash: string, - setter: (x?: any) => void, - remover: (x?: any) => void + setter: (x?: unknown) => void, + remover: (x?: unknown) => void ) { const queue = useQueueStore(); const is_current = diff --git a/src/composables/fetch/album.ts b/src/composables/fetch/album.ts index a036879..a0bf62e 100644 --- a/src/composables/fetch/album.ts +++ b/src/composables/fetch/album.ts @@ -8,7 +8,6 @@ const { albumartists: albumArtistsUrl, albumbio: albumBioUrl, albumsByArtistUrl, - favAlbums, } = paths.api; const getAlbumData = async (hash: string, ToastStore: typeof useNotifStore) => { diff --git a/src/config.ts b/src/config.ts index 9adba1c..1665c42 100644 --- a/src/config.ts +++ b/src/config.ts @@ -1,4 +1,4 @@ -let development = import.meta.env.DEV; +const development = import.meta.env.DEV; const dev_url = "http://localhost:1970"; const baseApiUrl = development ? dev_url : ""; diff --git a/src/utils/useCalculateSearchItemCount.ts b/src/utils/useCalculateSearchItemCount.ts deleted file mode 100644 index d21a7e0..0000000 --- a/src/utils/useCalculateSearchItemCount.ts +++ /dev/null @@ -1,6 +0,0 @@ -const itemWidth = 160; -const itemMarginBottom = 24; - -export default (containerWidth = 0, containerHeight = 0) => { - return Math.floor(containerWidth / itemWidth); -}; diff --git a/src/utils/useCreateTrackProps.ts b/src/utils/useCreateTrackProps.ts index 3f24bc4..bfca66e 100644 --- a/src/utils/useCreateTrackProps.ts +++ b/src/utils/useCreateTrackProps.ts @@ -1,6 +1,4 @@ import { Track } from "@/interfaces"; -import queue from "@/stores/queue"; -import { toRef } from "vue"; export default function createTrackProps(track: Track) { return { diff --git a/src/utils/usePutCommas.ts b/src/utils/usePutCommas.ts index 0461300..d66a607 100644 --- a/src/utils/usePutCommas.ts +++ b/src/utils/usePutCommas.ts @@ -4,7 +4,7 @@ * @returns a string with commas in between each artist */ export default (artists: string[]) => { - let result: string[] = []; + const result: string[] = []; artists.forEach((i, index, artists) => { if (index !== artists.length - 1) {