unrelated TODOs

This commit is contained in:
João Marcos 2025-05-05 21:11:44 -03:00
parent afbf0aaa75
commit e15cb83bd4
2 changed files with 3 additions and 0 deletions

View File

@ -37,6 +37,8 @@ jobs:
strategy:
fail-fast: false
matrix:
# TODO: avoid exploding the matrix by removing unrar and bzip3 from the all combinations runs
# I can add a monthly run with all combinations
feature-unrar: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[true]')}}
feature-bzip3: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[true]')}}
feature-use-zlib: ${{ inputs.matrix_all_combinations && fromJSON('[true, false]') || fromJSON('[false]')}}

View File

@ -158,6 +158,7 @@ pub fn run(
if let Some(format) = args.format {
let format = parse_format_flag(&format)?;
for path in files.iter() {
// TODO: use Error::Custom
let file_name = path.file_name().ok_or_else(|| Error::NotFound {
error_title: format!("{} does not have a file name", EscapedPathDisplay::new(path)),
})?;